Core Viewpoint - Linus Torvalds criticized a recent RISC-V code submission from a Google engineer, labeling it as "garbage" and highlighting issues with its quality and late submission timing [1][4][19] Submission Issues - The RISC-V code updates were submitted too late, just before the closing of the Linux 6.17 merge window, which led to Torvalds' strong disapproval [4][19] - The engineer, Palmer Dabbelt, acknowledged his mistakes regarding late submissions and expressed intent to improve the quality of future contributions [17] Code Quality Concerns - Torvalds specifically pointed out that some of the code included in the submission was not exclusive to RISC-V and deemed it unnecessary, which he felt would degrade overall code quality [8][10] - He provided examples of poor coding practices, emphasizing that certain functions made the code less readable and more complicated than necessary [10][11] Community Reactions - The incident sparked discussions within the community, with some mocking Torvalds' approach while others defended his direct communication style as effective [18] - Torvalds' history of blunt criticism has been noted, with past apologies for his behavior, yet he continues to maintain high standards for code submissions [17][18] Future Expectations - The RISC-V features will need to wait for the Linux v6.18 release, with a clear directive that future submissions must be made early in the merge window and free of "garbage" code [19]
Linus怒喷Google工程师:代码垃圾又迟交,别想轻易混进Linux!