Core Viewpoint - Linus Torvalds publicly criticized a Google engineer's RISC-V code submission for Linux 6.17, labeling it as "garbage" due to its poor quality and late submission [2][3][5]. Group 1: Criticism of Code Quality - Torvalds emphasized that the newly submitted RISC-V code contained unnecessary and poor-quality additions that do not pertain specifically to RISC-V [6][9]. - He provided examples of problematic code, such as the "make_u32_from_two_u16()" helper function, which he argued complicates understanding and makes the code worse [7][9]. - Torvalds insisted that such low-quality submissions should not be sent, especially late in the merge window, and warned developers against future late submissions [10][9]. Group 2: Developer Communication - Torvalds's comments were not merely harsh; he aimed to provide constructive feedback to improve code quality and adherence to submission timelines [3][4]. - He advised developers to submit their pull requests early in the merge window and to ensure that the code is of high quality, stating that "no more garbage" should be submitted [10][9]. - The response from social media regarding Torvalds's outburst was mixed, with some appreciating his directness and others questioning his approach [3].
Linus Torvalds 称谷歌工程师的 RISC-V 代码是垃圾