Core Viewpoint - Linus Torvalds criticized a recent RISC-V code submission from a Google engineer, labeling it as "garbage" and highlighting issues with its quality and timing, which sparked controversy in the tech community [1][4][18]. Group 1: Incident Overview - The incident involved Google Android engineer Palmer Dabbelt submitting RISC-V architecture updates to the Linux 6.17 merge window just before its closure [2][4]. - Linus Torvalds rejected the submission, stating it was submitted too late and criticized the quality of the code [4][5]. Group 2: Specific Code Issues - Torvalds pointed out that the submission included irrelevant code that was not specific to RISC-V, which he deemed inappropriate for the general header files [7][10]. - He provided examples of poor coding practices, such as the unnecessary use of a helper function that obscured code readability [9][10]. Group 3: Response and Community Reaction - Palmer Dabbelt acknowledged the criticism and expressed intent to improve submission practices to avoid late and low-quality contributions in the future [17]. - The incident reignited discussions in the community about Torvalds' direct communication style, with some defending his approach as efficient and necessary [18].
Linus 怒喷谷歌工程师:代码垃圾又迟交,别想轻易混进 Linux!